Update the custom AudioStream tutorial to Godot 4 #9792
+111
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
added
enhancement
area:contributing
|
Are these changes specific to Godot 4.4 or are they relevant for 4.3 as well? |
|
I think they go all the way back to godot 4.0, since the tutorial was broken back then to. I'll try to recompile older versions of godot with the module as far back as I can to see where it starts breaking, and update you in a bit. |
|
Yup, it works on 4.0.4-stable too! |
skyace65
changed the title
AThousandShips
changed the title
AThousandShips
requested changes
Sep 18, 2024
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
contributing/development/core_and_modules/custom_audiostreams.rst
Outdated
Show resolved
Hide resolved
|
You will still need to fix the indentation and empty lines, otherwise the style looks good, will try to test this soon as well |
|
I think I fixed all the empty lines I missed before, and indentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix #9231 #6170