Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update VisualShader page for 4.3 #9400

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

skyace65
Copy link
Contributor

@skyace65 skyace65 commented May 19, 2024

Updates the visual shader page for Godot 4.3. There was a major redesign of it in godotengine/godot#85017. I've also documented the new reroute node added in godotengine/godot#90534.

This solves some of the issues in #7563. The only images that still need to be updated are some from the last section, I was unable to put together visual shaders I could use for screenshots.

@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation topic:shaders labels May 19, 2024
@skyace65 skyace65 added this to the 4.3 milestone May 19, 2024
@skyace65 skyace65 marked this pull request as ready for review July 27, 2024 01:54
@skyace65
Copy link
Contributor Author

@clayjohn is this something you want to review?

Copy link
Contributor

@paddy-exe paddy-exe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyace65
Copy link
Contributor Author

skyace65 commented Aug 7, 2024

CC @mhilbrunner

@mhilbrunner mhilbrunner merged commit 7503ecb into godotengine:master Aug 7, 2024
1 check passed
@mhilbrunner
Copy link
Member

Thank you! And thanks everyone for the reviews. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:shaders
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants