Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix android SDK versions in exporting for android #6996

Merged
merged 3 commits into from
Apr 4, 2023
Merged

Fix android SDK versions in exporting for android #6996

merged 3 commits into from
Apr 4, 2023

Conversation

garryod
Copy link
Contributor

@garryod garryod commented Mar 16, 2023 •
edited by mhilbrunner
Loading

Update the versions of the following android SDK elements in the exporting for android doc:

  • platforms;android-31 to platforms;android-32
  • build-tools;31.0.3 to build-tools;32.0.0

As required by build

Docs team note: Squash and merge once godotengine/godot#75203 is merged, cherry-picked to 4.0 and live.

@mhilbrunner mhilbrunner added bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Mar 23, 2023
@mhilbrunner
Copy link
Member

cc @m4gr3d

m4gr3d
m4gr3d reviewed Mar 26, 2023
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's update the values to match this upcoming change

godotengine/godot#75203

@mhilbrunner mhilbrunner marked this pull request as draft March 28, 2023 07:50
@skyace65 skyace65 marked this pull request as ready for review April 4, 2023 02:05
@skyace65
Copy link
Contributor

skyace65 commented Apr 4, 2023

godotengine/godot#75203 was merged so this PR is good to be merged.

@skyace65 skyace65 merged commit f285445 into godotengine:master Apr 4, 2023
@skyace65 skyace65 mentioned this pull request Apr 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d left review comments

@skyace65 skyace65 skyace65 approved these changes

@mhilbrunner mhilbrunner mhilbrunner approved these changes

Assignees
No one assigned
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garryod @mhilbrunner @skyace65 @m4gr3d