Fix missing signal connection in code sample in Making HTTP requests #6620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the GDScript version of the example code, it does not have the user reading the tutorial connect the button's pressed signal to the script causing the "_on_Button_pressed" function to not run.
Calinou
approved these changes
Jan 17, 2023
Calinou
changed the title
solorvox
pushed a commit
to solorvox/godot-docs
that referenced
this pull request
Jan 20, 2023
mhilbrunner
pushed a commit
that referenced
this pull request
Sep 10, 2024
|
Cherry-picked to 3.6 in #9936. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the GDScript version of the example code, it does not have the user reading the tutorial connect the button's pressed signal to the script causing the "_on_Button_pressed" function to not run. Issue seems to apply to all versions that use this syntax for signal connections.