Warn about non-tool plugin scripts in C# #6138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add warning about C# plugins not reloaded when they are not tools - Add `[Tool]` attribute to plugin scripts in examples so they are not lost on reload
neikeq
approved these changes
Sep 5, 2022
mhilbrunner
reviewed
Oct 15, 2022
mhilbrunner
reviewed
Oct 15, 2022
mhilbrunner
approved these changes
Oct 15, 2022
|
Thanks! 🎉 |
mhilbrunner
pushed a commit
that referenced
this pull request
Sep 10, 2024
* Warn about non-tool plugin scripts in C# - Add warning about C# plugins not reloaded when they are not tools - Add `[Tool]` attribute to plugin scripts in examples so they are not lost on reload
|
Cherry-picked to 3.6 in #9936. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Tool]attribute to plugin scripts in examples so they are not lost on reload (see [3.5] C# EditorInspectorPlugin.CanHandle(Godot.Object) was not called properly godot#64381)Not sure if using a list inside a warning is ok but I think it looks kind of ugly and I was getting an error but it seemed to work anyway.