Skip to content

Update Complying with Licenses page#5329

Closed
nathanfranke wants to merge 1 commit intogodotengine:masterfrom
nathanfranke:license-updates
Closed

Update Complying with Licenses page#5329
nathanfranke wants to merge 1 commit intogodotengine:masterfrom
nathanfranke:license-updates

Conversation

@nathanfranke
Copy link

  • Clarify that it is not legal advice.
  • Remove outdated third-party attributions, and point them to COPYRIGHT.txt instead.

@nathanfranke
Copy link
Author

nathanfranke commented Oct 17, 2021

I made an addon licensed under Unlicense which helps display a UI for licensing.

Note: It does attribute myself by default, because some jurisdictions require attribution even for public domain works.

https://github.com/nathanfranke/godot-licensing

https://godotengine.org/asset-library/asset/1079

screenshot

screenshot

@mhilbrunner
Copy link
Member

I'd like @akien-mga to give this a glance.

The legal advice note is okay I think, pointing to COPYRIGHT.txt is also a good idea (although not sure how good that works with third-party licensing and how it interacts with our "its fine if you just link to that page" thing).

No idea about the addon, but IMO pointing to a third-party addon on our license page may not be the best look? Unsure. Open for input. :)

@nathanfranke
Copy link
Author

nathanfranke commented Oct 25, 2021

I could also add a licensing demo to https://github.com/godotengine/godot-demo-projects and link to that instead, that would be more official.

Also, I think in addition to looking at COPYRIGHT.txt we can recommend they use the Engine copyright functions.

@mhilbrunner
Copy link
Member

mhilbrunner commented Oct 26, 2021

Thinking more, we may just want to link to https://godotengine.org/license and keep that up to date
Having all this in multiple places seems a little cumbersome (although that page links back to this page in the docs)

IMO having this information in a single, central place would be good

@nathanfranke
Copy link
Author

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

I don't think linking to a website, which requires internet access and might go down, satisfies the Expat requirement. It would also need to satisfy BSD-3, CC-BY, etc., which is very unlikely to be true for all of them.

@mhilbrunner
Copy link
Member

Ah, I didnt mean to replace COPYRIGHT.txt/the various licenses with the above page, but IMO we don't need both https://godotengine.org/license and the docs page. Those two can maybe be unified.

@nathanfranke
Copy link
Author

Updated and added some sample code on how to generate a licenses text label

@nathanfranke
Copy link
Author

I can't guarantee formatting checks will pass, so I'll need the workflows to be approved 🙂

Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. WDYT, @akien-mga?

@mhilbrunner mhilbrunner requested a review from akien-mga July 13, 2022 12:13
@skyace65 skyace65 added the area:about Issues and PRs related to the About section of the documentation and other general articles label Jan 13, 2023
@akien-mga
Copy link
Member

akien-mga commented Feb 13, 2023

There are some good updates in this page, but it also goes in the general direction of making the requirements very extreme, to a point where personally I'd skip using Godot and go for an engine with EULA just so that I don't have to deal with such requirements.

If the page starts by saying that I can't ship a game without consulting with an attorney, as a small indie dev, I would look for another engine that just asks me to keep a "Made with Unity" splash screen. (And I'm not saying that license compliance is easier with proprietary software - it's just that they don't care and nobody respects the license terms of e.g. FreeType which is included in Unity too. It's mentioned in their EULA, but not in any Unity game.)

Likewise, adding code examples on how to dump a ton of license text in people's credits is IMO not the right approach. It looks terrible, and that's not what most licenses require. Personally, I'm perfectly fine with folks linking to https://godotengine.org/license and letting that page do the attribution properly.

Eventually, I also intend to add a way to embed the editor's About dialog in the game, in a way that can be shown easily with e.g. a hotkey (for example Alt+L, or whatever wouldn't conflict with typical OS and in-game hotkeys). Then complying with licenses would be as simple as:

Made with Godot Engine
https://godotengine.org
(Press Alt+L for license details.)

In short, while I'm all for educating people on how to properly honor the licenses of the open source software they're using, this shouldn't require an attorney and a BA in License Law to comply with.

@Calinou
Copy link
Member

Calinou commented Feb 13, 2023

Eventually, I also intend to add a way to embed the editor's About dialog in the game, in a way that can be shown easily with e.g. a hotkey (for example Alt+L, or whatever wouldn't conflict with typical OS and in-game hotkeys). Then complying with licenses would be as simple as:

I started working on this a while ago, but didn't have time to complete it: https://github.com/Calinou/godot/tree/add-license-notices-gui

There's also godotengine/godot#51028 which is useful to automatically achieve license compliance in headless/server binaries.

@nathanfranke
Copy link
Author

nathanfranke commented Feb 13, 2023

Edit: see here: #5329 (comment)

@mhilbrunner
Copy link
Member

I'm going to close this for now due to the discussion outlined above. It may still be worthwhile to improve this page, but we should discuss what/how first. Thanks for taking the time with this PR :)

@nathanfranke nathanfranke deleted the license-updates branch April 13, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

archived area:about Issues and PRs related to the About section of the documentation and other general articles enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants