Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use only right-click to remove tile from gridmap #5241

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

nsrCodes
Copy link
Contributor

@nsrCodes nsrCodes commented Sep 12, 2021

The docs suggest to use shift + RMB. Which works too, but only RMB also works. This might confuse as later in the documentation shift + LMB is used for bulk selection.

Edit: This PR also adds a line to explain how to change floors when using gridmap.

@YuriSizov
Copy link
Contributor

YuriSizov commented Sep 12, 2021

Is it how it's supposed to work though?

@YuriSizov YuriSizov added the bug label Sep 12, 2021
@nsrCodes
Copy link
Contributor Author

nsrCodes commented Sep 12, 2021

I did not think of this as a bug. Because we use LMB to place a block so using RMB to remove was intuitive. How can I confirm this?

@nsrCodes
Copy link
Contributor Author

Also, can I add a small line explaining how to shift floors? Because they are not mentioned anywhere in this documentation and since I had never used a level editor before it wasn't directly obvious as to how to start drawing on another level.

@Calinou
Copy link
Member

Calinou commented Sep 12, 2021

Also, can I add a small line explaining how to shift floors? Because they are not mentioned anywhere in this documentation and since I had never used a level editor before it wasn't directly obvious as to how to start drawing on another level.

Sure 🙂

@YuriSizov
Copy link
Contributor

I did not think of this as a bug.

The label means it's a bug in the documentation. 🙃

How can I confirm this?

Well, you can look at the code, ask the one who made the tool, or wait for others to check this PR out in case they know.

Also, can I add a small line explaining how to shift floors?

Sure, it's okay to make other corrections to the article.

@nsrCodes
Copy link
Contributor Author

Confirmed! The code works only with LMB.
This PR that worked on improving gridmap clearly states this in its description too - godotengine/godot#25406

Sure, it's okay to make other corrections to the article.

I meant in the same PR?

@YuriSizov
Copy link
Contributor

I meant in the same PR?

Yes, it's okay to do this in the same PR. Squash it into one commit and use a more generic commit message if you do. Something like "Improve GridMaps tutorial and correct editor shortcuts".

@mhilbrunner mhilbrunner merged commit 64ddea7 into godotengine:master Sep 15, 2021
@mhilbrunner
Copy link
Member

Thanks and congrats on your first contribution to the Godot docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants