Update Environment and post processing for 4.6#11598
Merged
Merged
Conversation
skyace65
added
enhancement
area:manual
skyace65
force-pushed
the
AGX
branch
2 times, most recently
from
1df0724 to
20e6ae4
Compare
mhilbrunner
approved these changes
Jan 11, 2026
Member
mhilbrunner
left a comment
mhilbrunner
left a comment
There was a problem hiding this comment.
Thank you so much for updating all the images once again. :) LGTM, will wait a bit to give others a chance to glance at the content changes.
AThousandShips
approved these changes
Jan 12, 2026
| **Linear** or **AgX**. | ||
| **Linear**. If you're using AGX, the mobile renderer, and HDR in 2D is disabled, | ||
| then the value set here will be ignored, and a value of ``2.0`` will be used | ||
| instead |
Member
There was a problem hiding this comment.
Suggested change
| instead | |
| instead. |
|
|
||
| .. image:: img/environment_fog_depth_height.webp | ||
|
|
||
| Both of these fog types can have their curve tweaked, making their transition more or less sharp. |
Member
There was a problem hiding this comment.
Suggested change
| Both of these fog types can have their curve tweaked, making their transition more or less sharp. | |
| Both of these fog types can have their curves tweaked, making their transition more or less sharp. |
They are distinct curves ("Lisa and Bob came in their car")
| Two properties can be tweaked to make the fog effect more interesting: | ||
|
|
||
| The first is **Sun Scatter**, which makes use of the DirectionalLight3D's color | ||
| and energy in the current scene. When looking towards the directional light |
Member
There was a problem hiding this comment.
Suggested change
| and energy in the current scene. When looking towards the directional light | |
| and energy in the current scene. When looking toward the directional light |
Nitpick, US English generally drops the "s"
allenwp
requested changes
Jan 12, 2026
Contributor
allenwp
left a comment
allenwp
left a comment
There was a problem hiding this comment.
Thanks for the review request! This looks good enough to me, besides one small change suggestion that I’ve requested.
Contributor
Author
|
Fixed |
allenwp
approved these changes
Jan 13, 2026
AThousandShips
approved these changes
Jan 13, 2026
mhilbrunner
approved these changes
Jan 13, 2026
Member
|
Thank you, and thanks for the reviews everyone! Merged. 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what the title says, at least mostly. There's several things on this page that need to be updated that aren't 4.6 specific, however I've updated a few things in addition to the 4.6 changes.
Changes
Not changed in this PR, but needs updating at some point