Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow unicode class names #1574

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Sep 6, 2024

Depends on PR godotengine/godot#96501

@dsnopek dsnopek added the enhancement This is an enhancement on the current functionality label Sep 6, 2024
@dsnopek dsnopek added this to the 4.x milestone Sep 6, 2024
@dsnopek dsnopek requested a review from a team as a code owner September 6, 2024 22:25
@dsnopek
Copy link
Collaborator Author

dsnopek commented Sep 6, 2024

This will fail tests until the upstream Godot PR is merged

@dsnopek dsnopek force-pushed the unicode-class-names branch 2 times, most recently from d35fb0e to d8c21f3 Compare September 11, 2024 21:19
@dsnopek dsnopek requested a review from a team as a code owner September 11, 2024 21:19
@dsnopek
Copy link
Collaborator Author

dsnopek commented Sep 11, 2024

Hrm. Compiling locally, the tests work fine. However, on GitHub Actions, both GCC and MSVC don't like the UTC-8 identifiers in the C++ code. I tried setting the LANG and LC_ALL environment variables, hoping that would help with the GCC on Linux builds, but it had no effect.

This will need some more research to figure out!

@Repiteo
Copy link
Contributor

Repiteo commented Sep 18, 2024

After some local testing, it appears that the gcc used in CI is the culprit. Changing runs-on to ubuntu-latest eliminates that error entirely. I'm having no luck on identifying where/when this bug was actually fixed, just that the gcc used in ubuntu-20.04 has the bug.

No comment on the CMake equivalents, not familiar enough with that buildsystem.

@dsnopek
Copy link
Collaborator Author

dsnopek commented Sep 18, 2024

Thanks! I updated to Ubuntu 22.04, which we're using in the static checks already, and that fixes the Linux/GCC builds.

I'm testing out some flags to fix the MSVC build.

@dsnopek
Copy link
Collaborator Author

dsnopek commented Sep 18, 2024

Huzzah! The MSVC flag I tried is working, so this is now fully passing tests :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement on the current functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants