Replace legacy hooks with pre-commit Python tool
#1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repiteo
added
enhancement
Repiteo
force-pushed
the
pre-commit-hooks
branch
from
0c213bc
to
e0d363a
Compare
|
Thanks, this looks really great! Seems to work perfectly in my testing. Skimming the changes, they seem to match all the equivalents in the Godot repo. And all the code style fixes seem good to me too. |
dsnopek
approved these changes
Jun 25, 2024
|
Cherry-picked for 4.2 in PR #1527 |
|
Cherry-picked for 4.1 in PR #1529 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overhauls the hook system to utilize the main repo's
pre-commithook logic. Migrated relevant files and settings over as needed, as well as applying any detected changes. In particular, this changes the python formatting system fromblacktoruff& ensures all the tools used in the checks are now easily accessible viapyproject.toml. Themisc/hooksfolder was removed entirely, with all relevant logic being handled inmisc/scriptsor.pre-commit-config.yaml.