Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generating default values for StringName #1487

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Fix generating default values for StringName #1487

merged 1 commit into from
Jun 13, 2024

Conversation

AThousandShips
Copy link
Member

Cases other than &"" were not processed correctly

See godotengine/godot#91382 (comment)

@AThousandShips
Fix generating default values for StringName
6cd6c89 
Cases other than `&""` were not processed correctly
@AThousandShips AThousandShips added bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.2 labels Jun 13, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Jun 13, 2024
@AThousandShips AThousandShips requested a review from a team as a code owner June 13, 2024 14:59
@AThousandShips AThousandShips mentioned this pull request Jun 13, 2024
Merged
6 tasks
dsnopek
dsnopek approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@AThousandShips
Copy link
Member Author

I'll make a separate one adding NodePath argument defaults as well as they're missing from this part, but aren't currently used anywhere

@AThousandShips
Copy link
Member Author

Needs cherry-picking for 4.2 for the linked PR to work, so if possible that'd be good to get around

@AThousandShips AThousandShips mentioned this pull request Jun 13, 2024
Merged
@dsnopek dsnopek merged commit 6c40641 into godotengine:master Jun 13, 2024
12 checks passed
@AThousandShips AThousandShips deleted the arg_default_fix branch June 13, 2024 18:50
@dsnopek
Copy link
Collaborator

dsnopek commented Jun 14, 2024

Cherry-picked for 4.1 in PR #1491

@dsnopek
Copy link
Collaborator

dsnopek commented Jun 14, 2024

Cherry-picked for 4.2 in PR #1492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
bug This has been identified as a bug topic:buildsystem Related to the buildsystem or CI setup
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @dsnopek