Send completed message at end of iap restores. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Apr 12, 2023
plugins/inappstore/README.md
Outdated
| @@ -21,7 +21,10 @@ func check_events(): | |||
| # fields: product_id, transaction_id, receipt | |||
| ... | |||
| 'restore': | |||
| # fields: product_id, transaction_id, receipt | |||
| # fields: product_id, transaction_id, receipt elif event.result=="completed": | |||
There was a problem hiding this comment.
What does this elif statement in a comment do?
There was a problem hiding this comment.
oops, that's supposed to be another case. Fixed.
Code by John Girvin in godotengine/godot-proposals#242
akien-mga
approved these changes
Apr 12, 2023
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Hi, I'm wondering if there is a release planned with this fix? I hesitate to build from source since not very familiar with iOS or debugging on phone. |
|
(Got a build sorted out. This fix works great. For any other newbs, need to download "scons" e.g. brew install scons. And despite what the instruction page, for 3.x at least I had to build targets "debug" and "release", not "release_debug" and "release".) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code by John Girvin in
godotengine/godot-proposals#242
Bugsquad edit: