fixes bug subscription_offer_details=null #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PickleJesus123
force-pushed
the
billing-v5
branch
from
117e484
to
09b7e9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with subscriptions in the billing-v5 branch where subscription_offer_details were always coming back "null" when accessed within Godot. This was preventing me from getting "formatted price strings" etc, for my subscriptions.
The problem I identified is that instances of
ArrayList<Dictionary>generated duringconvertProductDetailsToDictionary()in GooglePlayBillingUtils.java were getting "nulled" as the data was passed to Godot throughemit_signal(). I converted allArrayList<Dictionary>toObject[]beforedictionary.put()is called, and it is no longer being nulled. With this fix, you can read subscription_offer_details successfully