Skip to content

Conversation

@Bromeon
Copy link
Member

@Bromeon Bromeon commented Aug 3, 2022

Newer NDKs don't work out of the box due to a Rust bug (only fixed in nightly).

See rust-lang/rust#85806, bbqsrc/cargo-ndk#22 and workaround c4dt/lightarti-rest#104.

@Bromeon Bromeon added bug c: tools Component: tooling, tests, IDEs, Cargo, Rust ecosystem labels Aug 3, 2022
@Bromeon Bromeon added this to the v0.10.1 milestone Aug 3, 2022
@Bromeon
Copy link
Member Author

Bromeon commented Aug 3, 2022

bors r+

@Bromeon Bromeon mentioned this pull request Aug 3, 2022
@bors
Copy link
Contributor

bors bot commented Aug 3, 2022

Build succeeded:

@bors bors bot merged commit 23b2af2 into godot-rust:master Aug 3, 2022
@Bromeon Bromeon deleted the bugfix/android-ndk branch August 3, 2022 21:23
@atonamy
Copy link

atonamy commented Nov 9, 2022

@Bromeon how to use this fix on the client machine?

@Bromeon
Copy link
Member Author

Bromeon commented Nov 9, 2022

@atonamy Probably update the NDK, too.

This PR only fixed the CI version, to have a reproducible, working build. Typically you can take CI as a start for local builds, too.

@atonamy
Copy link

atonamy commented Nov 10, 2022

@atonamy Probably update the NDK, too.

This PR only fixed the CI version, to have a reproducible, working build. Typically you can take CI as a start for local builds, too.

Is it possible to update documentation related to this issue? I think current doc is outdated. I spent some time before to figure out how to fix compile error related to NDK 25

@Bromeon
Copy link
Member Author

Bromeon commented Nov 10, 2022

@atonamy Yes, of course! I currently don't have the Android setup on my machine, so I might not be the best candidate to write the proper documentation.

Would you be willing to open a pull request in the book? 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug c: tools Component: tooling, tests, IDEs, Cargo, Rust ecosystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants