Add example project #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karroffel
force-pushed
the
add-example-project
branch
from
62b12d2 to
6a9e188
Compare
bors bot
added a commit
that referenced
this pull request
Oct 14, 2021
793: Fix clippy lints in nightly r=Bromeon a=Bromeon
Where "fix" means mostly "disable".
Lints turned off globally for the time being (might change in the future):
* `clippy::missing_safety_doc` -- requires each unsafe fn/trait to have a `# Safety` section.
Nice in theory, annoying for internals, and boilerplate-enforcing for obvious public cases.
* `clippy::if_then_panic` -- suggests that `if (!cond) { panic!(msg); }` be written as `assert!(cond, msg);`
Probably makes sense to enable later, but currently not possible due to [approx/#73](brendanzab/approx#73).
Lints turned of locally:
* `clippy::redundant_closure` -- works around false positive [rust-clippy/#7812](rust-lang/rust-clippy#7812)
* `dead_code` (compiler warning, not clippy) -- generated field `this` not always used. Naming it `_this` doesn't seem right, either.
Co-authored-by: Jan Haller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new example project,
hello_world, which contains the Rust sources as well as a Godot project that's ready to be used (apart from possibly adjusting theGDNativeLibraryfile).Further, it moves the previous
exampleintoexamples/misc_mesh_playground, where also a valid Godot project was added.