-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note added for https://github.com/godot-rust/gdext/pull/365 #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
Instead of adding a note to the now-outdated text, could you please adjust the text so that it reflects the status quo? The workaround should no longer be listed. You can still mention that by default, GDExtension runs all Rust classes, but that gdext explicitly changes this behavior.
Also, instead of linking to the PR, you could link to the ExtensionLibrary
API docs:
https://godot-rust.github.io/docs/gdext/master/godot/init/trait.ExtensionLibrary.html
Please also use footnote style for links: [Some text][id]
and on the bottom [id]: link
(see existing files).
Apologies for not using footnote-style for links, I have edited the 'Always-on' paragraph as per the status quo and changed the warning into a tip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, no need to apologize! 🙂
A few more comments, then should be good to go!
Co-authored-by: Jan Haller <[email protected]>
Co-authored-by: Jan Haller <[email protected]>
Thank you, and sorry for the inconvenience about the grammar. Are we good to go now? |
Thank you! |
warningtip