Fixing failed CI builds caused by remove_dir_all failure

[StatisMike]

Closes #616

[GodotRust]

API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-618

[Bromeon]

Thanks a lot! 🙂
This PR in its current form fixes your downstream race condition?

[Bromeon]

You can use assert_ne! here -- it's impossible that this is ever larger than 5.

[StatisMike]

Shoot, botched it a little, and with such straightforward logic. Never gone up to 5 retries yet, but I will change the while loop condition for this to happen (better error message)

[StatisMike]

Tested after changing the while loop condition, all green still

[Bromeon]

Still, the if retry_count >= 5 { panic!(...) } can be simplified using assert_ne!(...) 🙂

Suggested change

	if retry_count >= 5 {
	panic!(
	"cannot remove directory: {path_display} after 5 tries with error: {err}",
	path_display = path.display()
	)
	}
	assert_ne!(
	retry_count, 5,
	"cannot remove directory {path} after 5 tries; error: {err}",
	path = path.display()
	)

[StatisMike]

@Bromeon Yeah, this fixes it, as soon as I changed the dependencies in gd-props branch to the current gdext master the error came back, so this solution seems to work.

[Bromeon]

Thank you!