Document + test limitations of Callable::from_local_static()
#1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
added
documentation
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1004 |
Bromeon
force-pushed
the
doc/callable-static-limitations
branch
from
295995b to
8f2da0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before Godot 4.4, there is no API to call static functions via reflection, so I had to be creative with the polyfill in #989.
As a result, the added
Callable::from_local_static()exposes some unintuitive behavior with the implementation on Godot 4.1 - 4.3:is_valid()returns false, even though the call itself will work.Callablecannot be used in signals (due to the above).This PR adds tests and documents this.