Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touchup styles #608

Merged
merged 6 commits into from
Nov 12, 2020
Merged

Touchup styles #608

merged 6 commits into from
Nov 12, 2020

Conversation

richtabor
Copy link
Contributor

@richtabor richtabor commented Nov 11, 2020 •
edited
Loading

Adds proper negative margin for fullwidth blocks
Removes unnecessary & nested selectors from block styles
Tweaks a few minor front-end to editor style mishaps.
Fix block quote style

@richtabor richtabor added [Priority] High This issue/pull request needs resolving before the next release [Status] Needs Review Tracking pull requests that need another set of eyes labels Nov 11, 2020
@richtabor richtabor added this to the Next Release milestone Nov 11, 2020
@richtabor richtabor requested a review from EvanHerman November 11, 2020 15:02
@richtabor richtabor self-assigned this Nov 11, 2020
@cypress
Copy link

cypress bot commented Nov 11, 2020 •
edited
Loading


Test summary

9 • 5 • 0 • 0

Run details
Project Go
Status Failed
Commit 3e41ce7
Started Nov 11, 2020 4:09 PM
Ended Nov 11, 2020 4:10 PM
Duration 00:56 💡
OS Linux Debian - 10.6
Browser Chrome 86

View run in Cypress Dashboard ➡️

Failures

barista-modern.spec.js 1 Failed
1 VR Testing: barista - modern > Loads frontpage
barista-welcoming.spec.js 1 Failed
1 VR Testing: barista - welcoming > Loads frontpage
barista-traditional.spec.js 1 Failed
1 VR Testing: barista - traditional > Loads frontpage
miller-traditional.spec.js 1 Failed
1 VR Testing: miller - traditional > Loads additional pages
miller-welcoming.spec.js 1 Failed
1 VR Testing: miller - welcoming > Loads additional pages

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

EvanHerman
EvanHerman approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@EvanHerman EvanHerman merged commit c780b55 into master Nov 12, 2020
@EvanHerman EvanHerman deleted the touchup-styles branch November 12, 2020 17:56
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.8 Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHerman EvanHerman EvanHerman approved these changes

Assignees

@richtabor richtabor

Labels
[Priority] High This issue/pull request needs resolving before the next release [Status] Needs Review Tracking pull requests that need another set of eyes
Projects
None yet
Milestone
1.3.8
Development

Successfully merging this pull request may close these issues.
2 participants
@richtabor @EvanHerman