Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visibility of WooCommerce checkboxes and radios #598

Merged
merged 4 commits into from
Nov 16, 2020
Merged

Fix visibility of WooCommerce checkboxes and radios #598

merged 4 commits into from
Nov 16, 2020

Conversation

EvanHerman
Copy link
Contributor

image

image

@EvanHerman EvanHerman added the [Type] Enhancement Something new that adds functionality label Nov 4, 2020
@EvanHerman EvanHerman added this to the Next Release milestone Nov 4, 2020
@EvanHerman EvanHerman requested a review from richtabor November 4, 2020 18:59
@EvanHerman EvanHerman self-assigned this Nov 4, 2020
@cypress
Copy link

cypress bot commented Nov 4, 2020 •
edited
Loading


Test summary

14 • 0 • 0 • 0

Run details
Project Go
Status Passed
Commit d7dcced
Started Nov 16, 2020 9:28 PM
Ended Nov 16, 2020 9:28 PM
Duration 00:56 💡
OS Linux Debian - 10.6
Browser Chrome 86

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@EvanHerman EvanHerman changed the title Fix visibility of checkboxes and radios Fix visibility of WooCommerce checkboxes and radios Nov 4, 2020
@richtabor
Copy link
Contributor

I think you forgot to pull in master's changes (PostCSS to SCSS). We don't need the & preceded anymore.

AnthonyLedesma
AnthonyLedesma approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the merge conflicts are resolved.

@EvanHerman EvanHerman merged commit 03a0739 into master Nov 16, 2020
@EvanHerman EvanHerman deleted the fix/woo-checkbox-radios branch November 16, 2020 21:34
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.9 Nov 19, 2020
@richtabor richtabor mentioned this pull request Jan 6, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyLedesma AnthonyLedesma AnthonyLedesma approved these changes

@richtabor richtabor Awaiting requested review from richtabor

Assignees

@EvanHerman EvanHerman

Labels
[Type] Enhancement Something new that adds functionality
Projects
None yet
Milestone
1.3.9
Development

Successfully merging this pull request may close these issues.
3 participants
@EvanHerman @richtabor @AnthonyLedesma