Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix radio group error notice visibility #579

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Conversation

EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Sep 3, 2020

Related: godaddy-wordpress/coblocks#1643

Radio group error notices weren't displaying because the radio buttons are set to appearance: none;.

Setting them to opacity: 0; lets the error notices to display properly.

form-radio-error

@EvanHerman EvanHerman added the [Type] Bug Something that is not working as expected label Sep 3, 2020
@EvanHerman EvanHerman added this to the Next Release milestone Sep 3, 2020
@EvanHerman EvanHerman self-assigned this Sep 3, 2020
@cypress
Copy link

cypress bot commented Sep 3, 2020



Test summary

14 0 0 0


Run details

Project Go
Status Passed
Commit de062bf
Started Sep 3, 2020 7:26 PM
Ended Sep 3, 2020 7:27 PM
Duration 01:16 💡
OS Linux Debian - 10.5
Browser Chrome 85

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@richtabor richtabor merged commit 6ed9cd1 into master Sep 3, 2020
@richtabor richtabor deleted the fix/radio-group-error branch September 3, 2020 19:47
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.6 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants