Menu hover/click settings toggle

[EvanHerman]

Resolves #529

This PR introduces a new customizer setting Menus > Menu Behavior > Show sub menus on hover.. This is false (unchecked) by default, so sites that are currently using the theme will see no changes. New users, or those who want to show submenus on hover can enable this setting.

• Unit tests have been added to maintain %100 coverage.
  https://8245-196281488-gh.circle-artifacts.com/0/phpunit-coverage/phpunit/html/index.html

Demo

[cypress]

---

Test summary

14 • 0 • 0 • 0

---

Run details

Project	Go
Status	Passed
Commit	32cf5b7
Started	Sep 2, 2020 10:57 PM
Ended	Sep 2, 2020 10:58 PM
Duration	01:04 💡
OS	Linux Debian - 10.5
Browser	Chrome 85

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[sirjonathan]

Just to confirm, will this allow the parent menu item to be clicked?

[richtabor]

Also, we should make this setting the default behavior (which will resolve the top-level menu item issue).

[EvanHerman]

@sirjonathan Correct. When the option is checked in the customizer, as outlined in the gif above, you'll be able to click the top level menu item.

[EvanHerman]

There still seems to be some weird behavior on mobile, and the 'hover to show sub menu items' doesn't currently work when using header 4. I'm also not sure how hover it should behave on mobile. There isn't technically a hover state on mobile like there is when using a mouse.

[sirjonathan]

I'm happy to test this before you push it out, if it's helpful! Just point me in the right direction?

[richtabor]

I think we'll follow up with a few more tweaks for mobile, but its fine in its current form.