Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the CoBlocks Form block .custom-color label #574

Merged
merged 2 commits into from
Sep 2, 2020

Conversation

EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Aug 25, 2020

Related: godaddy-wordpress/coblocks#1646

Form labels will not change colors without the changes made here. They will work with other themes (Unless other themes are also overriding the label colors in the editor)

@EvanHerman EvanHerman added the [Status] Waiting Issues/PRs that are on hold label Aug 25, 2020
@EvanHerman EvanHerman added this to the Next Release milestone Aug 25, 2020
@EvanHerman EvanHerman self-assigned this Aug 25, 2020
@cypress
Copy link

cypress bot commented Aug 25, 2020



Test summary

14 0 0 0


Run details

Project Go
Status Passed
Commit 5c22559
Started Aug 28, 2020 5:03 PM
Ended Aug 28, 2020 5:04 PM
Duration 00:59 💡
OS Linux Debian - 10.5
Browser Chrome 85

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works when used with godaddy-wordpress/coblocks#1646

@richtabor richtabor self-requested a review September 1, 2020 17:35
@richtabor
Copy link
Contributor

This class should be the standardized .has-text-color, once the control is properly using PanelColorSettings.

@richtabor richtabor merged commit f9fbcdf into master Sep 2, 2020
@richtabor richtabor deleted the editor/exclude-form-label-custom-color branch September 2, 2020 15:36
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.6 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Waiting Issues/PRs that are on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants