Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header background fallback issue #564

Merged
merged 2 commits into from
Aug 6, 2020
Merged

Fix header background fallback issue #564

merged 2 commits into from
Aug 6, 2020

Conversation

richtabor
Copy link
Contributor

Removes the inappropriate fallback header background color to ensure that headers have proper styling.

Screen Shot 2020-08-06 at 2 04 37 PM

@richtabor richtabor added [Priority] Low This issue/pull request is not immediate [Status] Needs Review Tracking pull requests that need another set of eyes labels Aug 6, 2020
@richtabor richtabor added this to the Next Release milestone Aug 6, 2020
@richtabor richtabor requested a review from EvanHerman August 6, 2020 18:06
@richtabor richtabor self-assigned this Aug 6, 2020
@cypress
Copy link

cypress bot commented Aug 6, 2020



Test summary

14 0 0 0


Run details

Project Go
Status Passed
Commit 7f3183f
Started Aug 6, 2020 6:45 PM
Ended Aug 6, 2020 6:46 PM
Duration 01:01 💡
OS Linux Debian - 10.4
Browser Chrome 84

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@EvanHerman EvanHerman merged commit 36c9659 into master Aug 6, 2020
@EvanHerman EvanHerman deleted the fix/header-bg branch August 6, 2020 20:24
@EvanHerman EvanHerman removed the [Status] Needs Review Tracking pull requests that need another set of eyes label Aug 6, 2020
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.4 Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low This issue/pull request is not immediate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants