Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update style to ignore the future Media & Text card style #561

Merged
merged 5 commits into from
Aug 6, 2020
Merged

Update style to ignore the future Media & Text card style #561

merged 5 commits into from
Aug 6, 2020

Conversation

richtabor
Copy link
Contributor

This PR simply ignores the upcoming "Card" style we may add to CoBlocks for the Media & Text block.

@richtabor richtabor added [Type] Enhancement Something new that adds functionality [Priority] Low This issue/pull request is not immediate [Type] Gutenberg Issues/PRs related to the current version of the Gutenberg plugin labels Jul 29, 2020
@richtabor richtabor self-assigned this Jul 29, 2020
@richtabor richtabor removed the [Type] Enhancement Something new that adds functionality label Jul 29, 2020
@cypress
Copy link

cypress bot commented Jul 29, 2020 •
edited
Loading


Test summary

14 • 0 • 0 • 0

Run details
Project Go
Status Passed
Commit 0e1ceba
Started Jul 31, 2020 4:19 PM
Ended Jul 31, 2020 4:20 PM
Duration 01:10 💡
OS Linux Debian - 10.4
Browser Chrome 84

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@richtabor richtabor added this to the Next Release milestone Aug 6, 2020
@richtabor richtabor added the [Type] Enhancement Something new that adds functionality label Aug 6, 2020
@richtabor richtabor requested a review from EvanHerman August 6, 2020 18:59
EvanHerman
EvanHerman approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on my end. Good to merge.

@EvanHerman EvanHerman marked this pull request as ready for review August 6, 2020 20:40
@EvanHerman EvanHerman merged commit ad97eaf into master Aug 6, 2020
@EvanHerman EvanHerman deleted the fix/media-card-left branch August 6, 2020 20:40
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.4 Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHerman EvanHerman EvanHerman approved these changes

Assignees

@richtabor richtabor

Labels
[Priority] Low This issue/pull request is not immediate [Type] Enhancement Something new that adds functionality [Type] Gutenberg Issues/PRs related to the current version of the Gutenberg plugin
Projects
None yet
Milestone
1.3.4
Development

Successfully merging this pull request may close these issues.
2 participants
@richtabor @EvanHerman