Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix one column product grid #552

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Fix one column product grid #552

merged 5 commits into from
Jul 21, 2020

Conversation

EvanHerman
Copy link
Contributor

@EvanHerman EvanHerman commented Jul 13, 2020 •
edited
Loading

Before:
image

After:
image

@EvanHerman EvanHerman added [Priority] Low This issue/pull request is not immediate [Type] Woo Relevant to WooCommerce labels Jul 13, 2020
@EvanHerman EvanHerman added this to the 1.3.3 milestone Jul 13, 2020
@EvanHerman EvanHerman requested a review from richtabor July 13, 2020 18:26
@EvanHerman EvanHerman self-assigned this Jul 13, 2020
@cypress
Copy link

cypress bot commented Jul 13, 2020 •
edited
Loading


Test summary

14 • 0 • 0 • 0

Run details
Project Go
Status Passed
Commit 0387336
Started Jul 21, 2020 7:28 PM
Ended Jul 21, 2020 7:29 PM
Duration 00:53 💡
OS Linux Debian - 10.4
Browser Chrome 84

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@AnthonyLedesma AnthonyLedesma self-requested a review July 21, 2020 17:45
AnthonyLedesma
AnthonyLedesma requested changes Jul 21, 2020
View reviewed changes
Copy link
Member

@AnthonyLedesma AnthonyLedesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the changes look good, I have not been able to replicate the originally reported issue. Are we sure that these changes are still required with the release of GB 8.5.1?

richtabor
richtabor approved these changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@richtabor richtabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some tweaks. Looks good!

@richtabor richtabor requested a review from AnthonyLedesma July 21, 2020 19:28
@richtabor
Copy link
Contributor

I was still able to replicate, though I've tweaked the PR to fully resolve it.

@richtabor richtabor merged commit 2059297 into master Jul 21, 2020
@richtabor richtabor deleted the fix/one-column-woo branch July 21, 2020 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richtabor richtabor richtabor approved these changes

@AnthonyLedesma AnthonyLedesma Awaiting requested review from AnthonyLedesma

Assignees

@EvanHerman EvanHerman

Labels
[Priority] Low This issue/pull request is not immediate [Type] Woo Relevant to WooCommerce
Projects
None yet
Milestone
1.3.3
Development

Successfully merging this pull request may close these issues.
3 participants
@EvanHerman @richtabor @AnthonyLedesma