Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak svgs for improved accessibility #534

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Tweak svgs for improved accessibility #534

merged 2 commits into from
Jun 11, 2020

Conversation

richtabor
Copy link
Contributor

Closes #531

@richtabor richtabor added [Type] a11y Issues/PRs related to accessibility [Type] Enhancement Something new that adds functionality [Status] Needs Review Tracking pull requests that need another set of eyes labels Jun 8, 2020
@richtabor richtabor self-assigned this Jun 8, 2020
@cypress
Copy link

cypress bot commented Jun 8, 2020


Test summary

21 • 7 • 0 • 0

Run details
Project Go
Status Failed
Commit 9bc079d
Started Jun 8, 2020 7:01 PM
Ended Jun 8, 2020 7:02 PM
Duration 01:04 💡
OS Linux Debian - 10.4
Browser Multiple

View run in Cypress Dashboard ➡️

Failures

barista-modern.spec.js ⏯ 1 Failed
1 VR Testing: barista - modern > Loads additional pages
barista-traditional.spec.js ⏯ 1 Failed
1 VR Testing: barista - traditional > Loads additional pages
barista-welcoming.spec.js ⏯ 1 Failed
1 VR Testing: barista - welcoming > Loads additional pages
miller-traditional.spec.js ⏯ 1 Failed
1 VR Testing: miller - traditional > Loads additional pages
miller-welcoming.spec.js ⏯ 1 Failed
1 VR Testing: miller - welcoming > Loads additional pages
bento-welcoming.spec.js ⏯ 1 Failed
1 VR Testing: bento - welcoming > Loads additional pages
bento-modern.spec.js ⏯ 1 Failed
1 VR Testing: bento - modern > Loads additional pages

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

EvanHerman
EvanHerman approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EvanHerman EvanHerman merged commit 8e3c702 into master Jun 11, 2020
@EvanHerman EvanHerman deleted the tweak/ally-svgs branch June 11, 2020 17:52
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.0 Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanHerman EvanHerman EvanHerman approved these changes

Assignees

@richtabor richtabor

Labels
[Status] Needs Review Tracking pull requests that need another set of eyes [Type] a11y Issues/PRs related to accessibility [Type] Enhancement Something new that adds functionality
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

SVG are not fully accessible for Screen Reader User (Post Meta)
2 participants
@richtabor @EvanHerman