Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper and styles for more block #532

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Add wrapper and styles for more block #532

merged 3 commits into from
Jun 9, 2020

Conversation

richtabor
Copy link
Contributor

Closes #530
Screen Shot 2020-06-08 at 1 08 29 PM

@richtabor richtabor added [Priority] Low This issue/pull request is not immediate [Status] Needs Review Tracking pull requests that need another set of eyes labels Jun 8, 2020
@richtabor richtabor requested a review from EvanHerman June 8, 2020 17:11
@richtabor richtabor self-assigned this Jun 8, 2020
@cypress
Copy link

cypress bot commented Jun 8, 2020



Test summary

21 7 0 0


Run details

Project Go
Status Failed
Commit 77f79d2
Started Jun 8, 2020 5:58 PM
Ended Jun 8, 2020 6:01 PM
Duration 02:54 💡
OS Linux Debian - 10.4
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

bento-modern.spec.js Failed
1 VR Testing: bento - modern > Loads additional pages
barista-welcoming.spec.js Failed
1 VR Testing: barista - welcoming > Loads additional pages
barista-traditional.spec.js Failed
1 VR Testing: barista - traditional > Loads additional pages
barista-modern.spec.js Failed
1 VR Testing: barista - modern > Loads additional pages
miller-traditional.spec.js Failed
1 VR Testing: miller - traditional > Loads additional pages
bento-welcoming.spec.js Failed
1 VR Testing: bento - welcoming > Loads additional pages
miller-welcoming.spec.js Failed
1 VR Testing: miller - welcoming > Loads additional pages

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@EvanHerman EvanHerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I updated this PR with some unit tests so we're still at 100% coverage.

@richtabor richtabor added this to the Next Release milestone Jun 8, 2020
@richtabor richtabor merged commit 3808a20 into master Jun 9, 2020
@richtabor richtabor deleted the fix/read-more branch June 9, 2020 18:52
@EvanHerman EvanHerman modified the milestones: Next Release, 1.3.0 Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Low This issue/pull request is not immediate [Status] Needs Review Tracking pull requests that need another set of eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read-more-link missing alignment
2 participants