Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradient control #528

Merged
merged 4 commits into from
Jun 8, 2020
Merged

Fix gradient control #528

merged 4 commits into from
Jun 8, 2020

Conversation

richtabor
Copy link
Contributor

The gradient control within Gutenberg requires rgb formatting, instead of hsl. This PR resolves that.

Before:
gradients-not

After:
gradient-fixed

@richtabor richtabor added [Type] Bug Something that is not working as expected [Priority] High This issue/pull request needs resolving before the next release [Status] Needs Review Tracking pull requests that need another set of eyes labels Jun 5, 2020
@richtabor richtabor requested a review from EvanHerman June 5, 2020 18:02
@richtabor richtabor self-assigned this Jun 5, 2020
@cypress
Copy link

cypress bot commented Jun 5, 2020



Test summary

6 8 0 0


Run details

Project Go
Status Failed
Commit 92d97dd
Started Jun 8, 2020 5:13 PM
Ended Jun 8, 2020 5:14 PM
Duration 00:43 💡
OS Linux Debian - 10.4
Browser Firefox 77

View run in Cypress Dashboard ➡️


Failures

barista-welcoming.spec.js Failed
1 VR Testing: barista - welcoming > Loads additional pages
barista-traditional.spec.js Failed
1 VR Testing: barista - traditional > Loads additional pages
bento-welcoming.spec.js Failed
1 VR Testing: bento - welcoming > Loads additional pages
miller-welcoming.spec.js Failed
1 VR Testing: miller - welcoming > Loads additional pages
miller-traditional.spec.js Failed
1 VR Testing: miller - traditional > Loads additional pages
barista-modern.spec.js Failed
1 VR Testing: barista - modern > Loads additional pages
bento-modern.spec.js Failed
1 VR Testing: bento - modern > Loads frontpage
2 VR Testing: bento - modern > Loads additional pages

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@EvanHerman
Copy link
Contributor

@richtabor Looks good to me - we just need to fix the unit tests and figure out why those visual regression tests are failing. They might fast fail because the unit tests are failing first.

@richtabor richtabor merged commit 49b8cc3 into master Jun 8, 2020
@richtabor richtabor deleted the fix/gradients-in-editor branch June 8, 2020 17:40
@EvanHerman EvanHerman added this to the 1.3.0 milestone Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High This issue/pull request needs resolving before the next release [Status] Needs Review Tracking pull requests that need another set of eyes [Type] Bug Something that is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants