Skip to content

Bump jruby from 9.2.9.0 to 9.2.20.1#9855

Merged
chadlwilson merged 3 commits intogocd:masterfrom
chadlwilson:jruby-92-latest
Dec 22, 2021
Merged

Bump jruby from 9.2.9.0 to 9.2.20.1#9855
chadlwilson merged 3 commits intogocd:masterfrom
chadlwilson:jruby-92-latest

Conversation

@chadlwilson
Copy link
Member

@chadlwilson chadlwilson commented Nov 7, 2021

https://www.jruby.org/2021/12/01/jruby-9-2-20-1.html

Includes RubyGems bump to 3.x which was done in https://www.jruby.org/2020/02/18/jruby-9-2-10-0.html

Minor workaround done to fix use of binaries via JRuby on Windows (used only for scss-lint, which is deprecated and needs to be removed/replaced)

  • RubyGems now generates binstubs with jruby.exe hardcoded which breaks used by bundle exec using the way we invoke JRuby (custom launch of JVM and jruby-complete jar). Previously the bin stubs/rubygems/bundler were able to get RUBY from env, and use our custom bash script.
  • Raised Can't override ruby_exe in rubygems-generated Windows bin stubs with JRuby 9.2.10.0+ jruby/jruby#6960 for this change, but probably not important
  • Worked around by launching scss-lint directly without bundler which avoids needing to have one Jruby create another Jruby.

@chadlwilson chadlwilson changed the title Bump jruby from 9.2.9.0 to 9.2.20.0 Bump jruby from 9.2.9.0 to 9.2.20.1 Dec 5, 2021
…bs issues with later JRuby

RubyGems now generates binstubs with jruby.exe hardcoded. Previous it seemed to get RUBY from env, and use our custom bash script to re-launch JRuby. Don't really know why we were doing it this way, but it seemed to cause jruby/jruby#6960

In any case, launching directly seems to work fine. The alternative is to disable on Windows, but avoiding `bundle exec` and relying on our JRuby configuration seems good enough until we can get rid of JRuby, and/or get rid of scss-lint which is deprecated anyway.
@chadlwilson chadlwilson added this to the Release 21.4.0 milestone Dec 22, 2021
@chadlwilson chadlwilson marked this pull request as ready for review December 22, 2021 15:37
@chadlwilson chadlwilson merged commit fcdce4b into gocd:master Dec 22, 2021
@chadlwilson chadlwilson deleted the jruby-92-latest branch December 22, 2021 15:38
@chadlwilson chadlwilson added the java Pull requests that update Java code label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies java Pull requests that update Java code ruby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant