Bump jruby from 9.2.9.0 to 9.2.20.1#9855
Merged
chadlwilson merged 3 commits intogocd:masterfrom Dec 22, 2021
Merged
Conversation
cfe5648 to
3fb85eb
Compare
3fb85eb to
7991627
Compare
7991627 to
d167bf3
Compare
Includes RubyGems bump to 3.x https://www.jruby.org/2021/12/01/jruby-9-2-20-1.html
…bs issues with later JRuby RubyGems now generates binstubs with jruby.exe hardcoded. Previous it seemed to get RUBY from env, and use our custom bash script to re-launch JRuby. Don't really know why we were doing it this way, but it seemed to cause jruby/jruby#6960 In any case, launching directly seems to work fine. The alternative is to disable on Windows, but avoiding `bundle exec` and relying on our JRuby configuration seems good enough until we can get rid of JRuby, and/or get rid of scss-lint which is deprecated anyway.
d167bf3 to
dbc0a9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.jruby.org/2021/12/01/jruby-9-2-20-1.html
Includes RubyGems bump to 3.x which was done in https://www.jruby.org/2020/02/18/jruby-9-2-10-0.html
Minor workaround done to fix use of binaries via JRuby on Windows (used only for scss-lint, which is deprecated and needs to be removed/replaced)
bundle execusing the way we invoke JRuby (custom launch of JVM and jruby-complete jar). Previously the bin stubs/rubygems/bundler were able to getRUBYfrom env, and use our custom bash script.