[Date] Implement %y year without century parser / formatter; respect digits that are below maximum format length
#135
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 45.88% 46.31% +0.42%
==========================================
Files 47 47
Lines 17822 17827 +5
==========================================
+ Hits 8178 8256 +78
+ Misses 8180 8126 -54
+ Partials 1464 1445 -19 |
ohaibbq
changed the title
%y year without century parser / formatter%y year without century parser / formatter; respect digits that are below maximum format length
internal/function_time_parser.go
Outdated
| if err != nil { | ||
| return 0, fmt.Errorf("unexpected month number") | ||
| return 0, 0, fmt.Errorf("%s", err) |
internal/function_time_parser.go
Outdated
| day := splitted[2] | ||
| if len(year) != 4 || len(month) != 2 || len(day) != 2 { | ||
| return 0, fmt.Errorf("unexpected year-month-day format") | ||
| if text[progress] != separator { |
There was a problem hiding this comment.
Is a boundary check necessary ? ( if len(text) <= progress { return } )
There was a problem hiding this comment.
A boundary check would be useful. I'll add it.
|
@goccy Fixed and added tests! Thank you for your review 🎊 |
| y, err := strconv.ParseInt(year, 10, 64) | ||
| progress += 1 | ||
|
|
||
| mProgress, m, err := parseDigitRespectingOptionalPlaces(text[progress:], 1, 12) |
There was a problem hiding this comment.
Again, progress value is updated by L645, so boundary checks are necessary.
| return 0, fmt.Errorf("could not parse hour:minute format: character after hour [%s] is not a [:]", string(text)) | ||
| } | ||
| hProgress += 1 | ||
| mProgress, m, err := parseDigitRespectingOptionalPlaces(text[hProgress:], 0, 59) |
There was a problem hiding this comment.
Strings can be indexed at their ending boundary. The zero-length string will cause parseDigitRespectingOptionalPlaces to return an error.
fmt.Println("123"[3:]) # empty string
fmt.Println("123"[4:]) # index 4 out of bounds
Please see test case parse date with %F separator but no month for reproduction
There was a problem hiding this comment.
OK, It seems to be ok for slice processing.
ohaibbq
force-pushed
the
dan/date-element-y
branch
from
535005f
to
a569c3c
Compare
|
LGTM 👍 |
Year numbers without leading zeros are allowed
Closes #134
Closes #137
Part of #138