-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for join expression in array scans #130
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 45.82% 45.81% -0.01%
==========================================
Files 47 47
Lines 17800 17814 +14
==========================================
+ Hits 8156 8161 +5
- Misses 8182 8189 +7
- Partials 1462 1464 +2 |
Thanks for your contribution @hannes-ucsc! Could you add some test cases to
|
May I ask what your involvement is with this project? I'd like to make reasonably sure that further work by me is justified by a the likely prospect of it actually being merged. |
Fair question. I'm just another user of the library but will be starting to contribute actively this quarter. We maintain a fork at Recidiviz/go-zetasqlite |
@hannes-ucsc ( cc @ohaibbq ) |
Since there is no response, this PR is closed. @ohaibbq If you can support this problem, I would appreciate your supports 🙏 |
I had forgotten about this PR and provided a fully implemented fix in #180 as it was causing a failing unit test in my other project. |
This query
when run in bigquery-emulator against a table whose
content
column is JSON with indirectly nested arrays, segfaults withThe first commit in this PR addresses that. The second commit adds support for the
ON <joinExpr>
clause to array scans such as used in the above query.I don't know Go and am not familiar with this extremely useful project so I present this PR more as an elaborate issue report as opposed to something I think should or can be merged as is. It probably needs work but it makes my use cases work.