Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ActiveRecord::Base.default_timezone #446

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

floriandejonckheere
Copy link
Contributor

@floriandejonckheere floriandejonckheere commented Dec 24, 2021

Rails 7.0 deprecates ActiveRecord::Base.default_timezone in favour of ActiveRecord.default_timezone. Rails 7.1 will remove this method entirely. To prevent deprecation warnings in 7.0, the gem should default to the new method.

@shkm
Copy link

shkm commented Feb 2, 2022

@thom-oman not quite sure who to ping so apologies if you're not the right one for this, but what's the state of statesman (heheh)? It'd be great if we could get this tiny change in.

@thom-oman
Copy link
Contributor

Hey @shkm! Yeah I'm still keeping an eye on statesman but still finding less time than I'd like. So it's definitely not been receiving the love it deserves over the past few months 😅 but leave that with me, I'm going to try get the ball moving on that today.

In terms of this PR, I will also release it today, so we can get rid of those annoying warnings! :)

Apologies again for the slowness, think this PR in particular was missed over the christmas period.

@thom-oman thom-oman merged commit 16207a9 into gocardless:master Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants