add tcp reconnect when write failed #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the function
func (mb * tcpTransporter) Send (aduRequest [] byte) (aduResponse [] byte, err error) {...}, if there is an error occur when Write data, it returns directly; Imagine the following scenario: while frequently collecting data from Modbus devices, if the Modbus device is shut down abnormally due to sudden power failure or other reasons after a normal TCP connection, and then immediately restarted; At this point, the TCP connection mb.conn in the code is no longer available and will generate an error message: write: broken pipe， However, mb.com is not immediately reclaimed and set to nil. The system usually takes several hours to reclaim mb.com or manually intervene in the program to reconnect, resulting in a large amount of data being missed in between; So when an error occurs when Write data, mb. close() can be called, set conn nil for the next request to reconnect when mb. connect() is executed.