fix: make disableEager not trigger the race detector #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zepatrik
force-pushed
the
origin/fix/eager-race-detector
branch
2 times, most recently
from
107833e to
023aee7
Compare
zepatrik
commented
Jul 12, 2022
| @@ -533,6 +534,21 @@ func Test_Create_Non_PK_ID(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func Test_Create_Parallel(t *testing.T) { | |||
There was a problem hiding this comment.
As you can see, this test failed first with the data race: https://github.com/gobuffalo/pop/runs/7304729964?check_suite_focus=true#step:6:47
==================
WARNING: DATA RACE
Read at 0x00c000074ca0 by goroutine 103:
github.com/gobuffalo/pop/v6.(*Connection).Create()
/home/runner/work/pop/pop/executors.go:176 +0x90
github.com/gobuffalo/pop/v6.Test_Create_Parallel.func1.1()
/home/runner/work/pop/pop/executors_test.go:546 +0x147
testing.tRunner()
/opt/hostedtoolcache/go/1.18.3/x64/src/testing/testing.go:1439 +0x213
testing.(*T).Run.func1()
/opt/hostedtoolcache/go/1.18.3/x64/src/testing/testing.go:1486 +0x47
Previous write at 0x00c000074ca0 by goroutine 80:
github.com/gobuffalo/pop/v6.(*Connection).disableEager()
/home/runner/work/pop/pop/connection.go:244 +0xbc
github.com/gobuffalo/pop/v6.(*Connection).Create()
/home/runner/work/pop/pop/executors.go:178 +0xa1
github.com/gobuffalo/pop/v6.Test_Create_Parallel.func1.1()
/home/runner/work/pop/pop/executors_test.go:546 +0x147
testing.tRunner()
/opt/hostedtoolcache/go/1.18.3/x64/src/testing/testing.go:1439 +0x213
testing.(*T).Run.func1()
/opt/hostedtoolcache/go/1.18.3/x64/src/testing/testing.go:1486 +0x47
ed5da98 to
adc17e5
Compare
|
OK the tests are still not working, I'll fix them tomorrow... |
zepatrik
force-pushed
the
origin/fix/eager-race-detector
branch
from
adc17e5 to
1de2d66
Compare
zepatrik
commented
Jul 13, 2022
| @@ -13,7 +13,7 @@ services: | |||
| ports: | |||
| - "3306:3306" | |||
| postgres: | |||
| image: postgres:9.6 | |||
| image: postgres:10.21 | |||
There was a problem hiding this comment.
Previous test failure was related to some postgres bug. As 9.6 is not supported anymore, I bumped to a supported version.
zepatrik
force-pushed
the
origin/fix/eager-race-detector
branch
from
1de2d66 to
58adbcc
Compare
aeneasr
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a bit of code search I figured that the race detection mentioned in #723 is kind of a false positive. Adding this check ensures the race detector is not triggered.