Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eager creation for associations by adding where clause #607

Merged
merged 2 commits into from
Sep 24, 2022
Merged

fix eager creation for associations by adding where clause #607

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf055a2
fix eager creation for associations by adding where clause
xixinjie Dec 4, 2020
d515d5a
check if exists by id
xixinjie Dec 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion executors.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,8 @@ func (c *Connection) Create(model interface{}, excludeColumns ...string) error {
if IsZeroOfUnderlyingType(id) {
return c.Create(m.Value)
}
exists, errE := Q(c).Exists(i)

exists, errE := Q(c).Where("id = ?", id).Exists(i)
Copy link
Member

@aeneasr aeneasr Jan 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ID column is variable depending on the struct and should therefore not be hardcoded. m has a function whereID which should be used instead.

if errE != nil || !exists {
return c.Create(m.Value)
}
Expand Down