Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regex bug on the WHERE col IN (?) #778

Closed
Tracked by #770
sio4 opened this issue Sep 23, 2022 · 0 comments · Fixed by #779
Closed
Tracked by #770

fix regex bug on the WHERE col IN (?) #778

sio4 opened this issue Sep 23, 2022 · 0 comments · Fixed by #779
Assignees
@sio4
Labels
bug Something isn't working s: fixed was fixed or solution offered
Milestone
v6.0.7

Comments

@sio4
Copy link
Member

sio4 commented Sep 23, 2022

fix regex bug

and has a bug between the regex selection and what strings.Replace replaces (selects (\s*?\s*) but only replaces
(?)

This is a valid point, I would like to file a new PR for this to fix this bug.

Some references:

Originally posted by @sio4 in #524 (comment)
@sio4 sio4 mentioned this issue Sep 23, 2022
Closed
30 tasks
@sio4 sio4 self-assigned this Sep 23, 2022
@sio4 sio4 added this to the v6.0.7 milestone Sep 23, 2022
@sio4 sio4 added bug Something isn't working s: accepted This proposal was accepted. Someone can start working on it. labels Sep 23, 2022
sio4 added a commit that referenced this issue Sep 23, 2022
@sio4
fixed replacing bug on WHERE IN statement (fixes #778)
b1734d8
@sio4 sio4 mentioned this issue Sep 23, 2022
Merged
@sio4 sio4 closed this as completed in #779 Sep 24, 2022
@sio4 sio4 closed this as completed in 30ded0f Sep 24, 2022
@sio4 sio4 added s: fixed was fixed or solution offered and removed s: accepted This proposal was accepted. Someone can start working on it. labels Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sio4 sio4

Labels
bug Something isn't working s: fixed was fixed or solution offered
Projects
None yet
Milestone
v6.0.7
Development

Successfully merging a pull request may close this issue.

fixed replacing bug on WHERE IN statement (fixes #778) gobuffalo/pop
1 participant
@sio4