catch out of bounds slice/array index access #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paganotoni Just a friendly reminder :) |
|
Thanks for the reminder @Mido-sys. I left a couple of minor things to tweak. this is looking good. |
|
@paganotoni sounds good. Thank you. |
|
@paganotoni, Sorry, I misread your comment. Did you mean that you left some notes for me to improve? |
|
Yes just a few small things. |
|
@paganotoni, where did you leave your comments? I can't find it. |
paganotoni
requested changes
Oct 27, 2021
|
@Mido-sys I had that review in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An error will return to the user if they try to access an index that doesn't exist.
Example:
array index out of bounds, got index 5, while array size is 5