Merge pull request #152 from Mido-sys/fix_panic_empty_if_condition

Fix panic when the if condition is empty
gobuffalo · Mar 24, 2022 · 6c2169a · 6c2169a
2 parents ea58c23 + 986a844
commit 6c2169a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/parser/parser.go b/parser/parser.go
@@ -814,6 +814,10 @@ func (p *parser) registerInfix(tokenType token.Type, fn infixParseFn) {
 }
 
 func (p *parser) confrimIfCondition(v ast.Expression) (returnData bool) {
+	if v == nil {
+		p.invalidIfCondition("missing condition in if statement")
+		return
+	}
 	_, ok := v.(ast.Comparable)
 	if !ok {
 		p.invalidIfCondition(v.String())

diff --git a/parser/parser_test.go b/parser/parser_test.go
@@ -1114,6 +1114,14 @@ func Test_Break_IfCondtion(t *testing.T) {
 	r.Error(err)
 }
 
+func Test_Empty_IfCondtion(t *testing.T) {
+	r := require.New(t)
+	input := `<% if() { v } %>`
+
+	_, err := Parse(input)
+	r.Error(err)
+}
+
 func Test_Continue_Function(t *testing.T) {
 	r := require.New(t)
 	input := `<% fn(x, y) { continue } %>`