Skip to content
This repository has been archived by the owner on Jun 25, 2022. It is now read-only.

Print version on new line #246

Merged
merged 2 commits into from
Mar 1, 2020
Merged

Conversation

laynemcnish
Copy link
Contributor

When running packr version, it should print the version on it's own line.

Current behavior:

$ packr version
v2.5.3$

New behavior:

$ packr version
v2.5.3
$

When checking the recommended behavior against Cobra, their example uses Println, as well.

var versionCmd = &cobra.Command{
  Use:   "version",
  Short: "Print the version number of Hugo",
  Long:  `All software has versions. This is Hugo's`,
  Run: func(cmd *cobra.Command, args []string) {
    fmt.Println("Hugo Static Site Generator v0.9 -- HEAD")
  },
}

@thisiskseniab
Copy link

Yes, please! This would be super nice to have 🙌

@laynemcnish laynemcnish requested a review from a team as a code owner March 1, 2020 08:06
@stanislas-m stanislas-m merged commit e63e9f6 into gobuffalo:master Mar 1, 2020
@stanislas-m
Copy link
Member

Sorry for the delay, and thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants