Add failing test case for drop_column #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ALTER TABLE .. RENAME COLUMN .. TO ..` is officially supported and does not need the temporary table workaround.
aeneasr
force-pushed
the
fix-drop
branch
2 times, most recently
from
19881e6
to
73a77c9
Compare
|
|
|
Using the e2e tests I found more bugs in CockroachDB which prevented e.g. unique indices from being created properly. So gonna be addressing those and then hopefully everything will pass soon. |
CockroachDB v2.1 has reached EOL on 7/1/20. The next version v19.1 already reached maintenance support and will reach EOL in 11/1/20 which is why this was bumped to v19.2 right away.
Resolves an issue where CockroachDB would be missing e.g. UNIQUE indices when using `change_column`. Also fixes a bug when using `change_column` with `NOT NUL` but without `DEFAULT`.
|
Ok, everything is passing now and several bugs have been resolved with this patch :) Good for 👀 now! |
stanislas-m
approved these changes
Aug 30, 2020
|
Thanks @aeneasr! |
aeneasr
added a commit
to ory/kratos
that referenced
this pull request
Aug 31, 2020
Completely refactors the verification flow to support other methods. The original email verification flow now moved to the "link" method also used for recovery. Additionally, several upstream bugs in gobuffalo/pop and gobuffalo/fizz have been addressed, patched, and merged which improves support for SQLite and CockroachDB migrations: - gobuffalo/fizz#97 - gobuffalo/fizz#96 BREAKING CHANGE: This patch significantly changes how email verification works. The Verification Flow no longer uses its own system but now re-uses the API and Browser flows and flow methods established in other components such as login, recovery, registration. Due to the many changes these patch notes does not cover how to upgrade this particular flow. We instead want to kindly ask you to check out the updated documentation for this flow at: https://www.ory.sh/kratos/docs/self-service/flows/verify-email-account-activation This patch changes the SQL schema and thus requires running the SQL Migration command (e.g. `... migrate sql`). Never apply SQL migrations without backing up your database prior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a failing test case for using drop_column with SQLite. For more context, see gobuffalo/pop#574
Please note that this PR builds on top of #95