This repository has been archived by the owner on Feb 24, 2024. It is now read-only.
made panic event to use the same standard payload type #2352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being done in this PR?
made
PanicHandleremits an error event with the standard payload as the same asdefaultErrorMiddleware.Now, stack trace can be accessed by
e.Payload["stacktrace"](previously, we need to assert ife.Payload["data"]is a map, and then use that asasserted["stacktrace"]). It could be a breaking change if someone uses the buggy data structure as is, but I want to say this is a kind of bugfix :-)(also, updated module dependencies)
What are the main choices made to get to this solution?
Consistent behavior and data structure for all error events, by using the standard payload type.