Run dead code analysis with reanalyze #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Did you try to run Gobview after these changes @sim642? Seems odd that so many files can be completely removed! |
It compiles without problems both locally and on the analyzer repo CI. Since these are all OCaml/ReasonML files, if it compiles without them, they were unused. I'm not sure, but the XML/DOM seems to have been related to trying to parse Goblint's XML output in some earlier attempt. |
Yeah, that's exactly what it was for. Can be safely removed now. |
keremc
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, adapts Gobview to goblint/analyzer#737.
Second, also runs reanalyze on Gobview itself to find dead code here as well.