Skip to content

Conversation

@jerhard
Copy link
Member

@jerhard jerhard commented Jan 13, 2022

The accepted json-format changed, the option "exp.solver" moved to "solver"and "solvers". This PR fixes the config files so that ./update_bench_incremental.rb 60 index/defs/incremental.yaml index/sets/posix.yaml works again

@jerhard jerhard requested a review from vesalvojdani January 13, 2022 09:25
@jerhard jerhard added the bug label Jan 13, 2022
@sim642
Copy link
Member

sim642 commented Jan 13, 2022

I think some index/defs/ files also mention the outdated option names.

Copy link
Member

@vesalvojdani vesalvojdani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks... I'll do some benchmark runs now.

@sim642
Copy link
Member

sim642 commented Jan 18, 2022

So this is good to merge, or?

@jerhard jerhard merged commit 7c8fa96 into master Jan 19, 2022
@vesalvojdani vesalvojdani deleted the fix_json_configs branch March 30, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants