Equip float domain to handle definite NaN, +Inf, -Inf, and some missing float stubs #869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-schwarz
force-pushed
the
float_nan_and_stubs
branch
from
92c675d to
ef8ca20
Compare
29 tasks
2 tasks
sim642
reviewed
Oct 31, 2022
Member
sim642
left a comment
sim642
left a comment
There was a problem hiding this comment.
I suppose the definite NaN/+inf/-inf domain could be extracted out to a separate float domain and be another component of FloatDomTuple, which could decouple things somewhat. But since it's already done, there's no point in redoing it right now.
sim642
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of #868 I came across a few tests for sv-comp that are low-hanging fruit that require handling the information that some variable is definitely NaN, +Inf or -Inf. This adds these possibilities.
The resulting lattice is a flat lattice with NaN, +Inf, -Inf, and intervals of actual floats values.
In the course of this PR, I will also add the float stubs sv-comp uses that I identified in #868.