Skip to content

Conversation

@sim642
Copy link
Member

@sim642 sim642 commented May 21, 2025

This should fix GobView being uninstallable after #1708.

TODO

@sim642 sim642 added setup Dependencies, CI, releasing parallel Parallel Goblint labels May 21, 2025
@sim642 sim642 marked this pull request as ready for review May 21, 2025 20:45
@sim642 sim642 added this to the v2.6.0 milestone May 21, 2025
@sim642 sim642 merged commit 2417ea4 into master May 22, 2025
47 checks passed
@sim642 sim642 deleted the gobview-ocaml5 branch May 22, 2025 07:06
@sim642
Copy link
Member Author

sim642 commented May 28, 2025

I'm not sure what's going on, but it's still broken in the nightly CI (https://github.com/goblint/analyzer/actions/runs/15290394782/job/43008642771):

{'level': 'SEVERE', 'message': 'webpack://gobview/./src/App.bc.js? 160178:36 Uncaught TypeError: runtime.caml_thread_self is not a function', 'source': 'javascript', 'timestamp': 1748401316557}

It's especially weird because it succeeded in the manual CI job I ran on the branch beforehand.

@michael-schwarz
Copy link
Member

Is it a dependency issue somehow? Or one of the newer PRs? Maybe worth bisecting?

@sim642
Copy link
Member Author

sim642 commented May 30, 2025

I didn't do a careful analysis, but one thing that changed was #1753, changing ocamlfind from 1.9.6 to 1.9.8. This is part of ocamlfind 1.9.7, but I don't know if this is the cause: ocaml/ocamlfind#76.

sim642 added a commit that referenced this pull request Jul 2, 2025
@sim642
Copy link
Member Author

sim642 commented Jul 2, 2025

I finally looked into it and looks like it was just batteries being used instead of batteries.unthreaded: 63df974. The GobView job finally succeeded after two months of daily failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parallel Parallel Goblint setup Dependencies, CI, releasing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants