Add weak dependencies to TD3 (rebased) #1747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
I redid the comparison on ConcurrencySafety from sv-benchmarks, but with full SV-COMP resource limits. The output is currently here, but the important plots are screenshotted below: https://goblint.cs.ut.ee/results/259-concurrency-weak-deps-before/table-generator-cmp.table.html#/. Quantile plotsEvals
CPU time
Scatter plots (before vs after-lazy)Evals
CPU time
DifferencesGoing from before to after-lazy also has an impact on 6 verdicts:
Although this doesn't give is more points in SV-COMP, these speedups are insane: at least 300×! Given all of this evidence, I'm proposing to make lazy weak dependencies the default in TD3. |
arkocal
reviewed
May 26, 2025
|
This looks good to me. Reminder that I cannot accepts PRs, hence the comment. |
arkocal
approved these changes
May 27, 2025
sim642
commented
May 27, 2025
michael-schwarz
approved these changes
May 28, 2025
sim642
added a commit
to sim642/opam-repository
that referenced
this pull request
Sep 5, 2025
CHANGES: * Add division by zero analysis (goblint/analyzer#1764). * Add bitfield domain (goblint/analyzer#1623). * Add weakly-relational C-2PO pointer analysis (goblint/analyzer#1485). * Add widening delay (goblint/analyzer#1358, goblint/analyzer#1442, goblint/analyzer#1483). * Add narrowing of globals to top-down solver (goblint/analyzer#1636). * Add weak dependencies to top-down solver (goblint/analyzer#1746, goblint/analyzer#1747). * Add YAML ghost witness generation (goblint/analyzer#1394). * Remove GraphML witness generation (goblint/analyzer#1732, goblint/analyzer#1733, goblint/analyzer#1738). * Use C standard option for preprocessing (goblint/analyzer#1807). * Add bash completion for array options (goblint/analyzer#1670, goblint/analyzer#1705, goblint/analyzer#1750). * Make `malloc(0)` semantics configurable (goblint/analyzer#1418, goblint/analyzer#1777). * Update path-sensitive analyses (goblint/analyzer#1785, goblint/analyzer#1791, goblint/analyzer#1792). * Fix evaluation of library function arguments (goblint/analyzer#1758, goblint/analyzer#1761). * Optimize affine equalities analysis using sparse matrices (goblint/analyzer#1459, goblint/analyzer#1625). * Prepare for parallelism (goblint/analyzer#1708, goblint/analyzer#1744, goblint/analyzer#1748, goblint/analyzer#1781, goblint/analyzer#1790).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of (the relevant parts of) #1743 on top of #1746.
It was easier to cherry-pick the necessary commits from #1743 to avoid conflicts with #1746. Also #1743 includes changes to unrelated solvers which would've needed reverting anyway. So this way we get a cleaner history.
TODO