Fix unsoundness bug in interval sets and refactor interval widen thresholds #1476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in IntervalSetFunctior, instead definining its own
karoliineh
added
cleanup
sim642
reviewed
May 21, 2024
Co-authored-by: Simmo Saan <[email protected]>
|
It would be nice to have tests for this. Instead of trying to construct programs with complex autotuning configurations, adding unit tests into |
sim642
approved these changes
May 21, 2024
michael-schwarz
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_ik(or smaller thanman_ik),max_ik(ormin_ik) is picked instead. (solves Interval sets are unsound due to larger-than-type ranges #1473)widen.upper_thresholdandwiden.lower_thresholdofIntervalFunctorandIntervalSetFunctortoIntervalArithmodule, and uses this function for both.