Generalize and clean up abs invariant in base analysis
#1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If it really is a generalization, it would be nice to have a new regression test that passes now. |
michael-schwarz
approved these changes
Nov 29, 2023
Member
michael-schwarz
left a comment
michael-schwarz
left a comment
There was a problem hiding this comment.
Once my comment above is addressed, I'd be happy to merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the
abshandling from #1253 and #1254 to happen at any level of the expression, just like other tmpSpecials. This change is in the first commit.The rest are some refactoring of the surrounding code because the indentation is already 14 tabs deep. I wanted to clean it up more, but the implementation of
__builtin_isgreater, etc is implemented hackily to convertNot{0}to1to1.0to represent it as the expected value for float domains.