Improve SV-COMP conf for no-data-race #1207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should be considered MemSafety issues instead.
This is required for some ldv-races/ no-data-race tasks.
Avoids a large number or CIL warnings about mismatching types.
This is enough for ldv-races/race-2_1-container_of, etc, but cheaper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
threadidthreadflagpath-sensitive. This is required for tasks likeldv-races/race-2_1-container_of.ymlwhere accesses happen based on conditional thread creation. The created threads set is part ofthreadid.freeand thread-unsafe function calls because they probably shouldn't count as races under SV-COMP rules. This allows us to solvegoblint-regression/04-mutex_36-trylock_nrwhich happens to containstrerrors.exp.architectureoption for preprocessing. Goblint's BenchExec tool-info module always passes this argument but we didn't use it (except for GraphML witnesses). By using it for preprocessing we avoid some annoying CIL type merging warnings that obscure the output.